BO : Right side block of attribute and attribute groups in combination tab not appears. #10392
Conversation
…n tab not appears.
|
Hello @dbadrukhiya! This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community! |
| @@ -543,7 +543,7 @@ public function formAction($id, Request $request) | |||
| } | |||
|
|
|||
| $doctrine = $this->getDoctrine()->getManager(); | |||
| $attributeGroups = $doctrine->getRepository('PrestaShopBundle:Attribute')->findByLangAndShop(1, 1); | |||
| $attributeGroups = $doctrine->getRepository('PrestaShopBundle:Attribute')->findByLangAndShop((int)$languages[0]['id_lang'], (int)['shop_id']); | |||
There was a problem hiding this comment.
Should be:
$attributeGroups = $doctrine->getRepository('PrestaShopBundle:Attribute')->findByLangAndShop((int) $languages[0]['id_lang'], (int) ['shop_id']);
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on @mreker and @dbadrukhiya)
src/PrestaShopBundle/Controller/Admin/ProductController.php, line 546 at r1 (raw file):
Previously, Mreker wrote…
Should be:
$attributeGroups = $doctrine->getRepository('PrestaShopBundle:Attribute')->findByLangAndShop((int) $languages[0]['id_lang'], (int) ['shop_id']);
Done.
src/PrestaShopBundle/Controller/Admin/ProductController.php, line 546 at r2 (raw file):
Previously, PierreRambaud (GoT) wrote…
(int) ['shop_id']isn't an id..
id_shop ?
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on @mreker and @PierreRambaud)
src/PrestaShopBundle/Controller/Admin/ProductController.php, line 546 at r2 (raw file):
Previously, dbadrukhiya (Dinesh Badrukhiya) wrote…
id_shop ?
Done.
|
@Quetzacoalt91 wdyt? |
|
Can anyone help me to remove this. I was trying to open new request but by mistake it showing here and accidentally deleted theme.css file also. |
| @@ -543,7 +543,8 @@ public function formAction($id, Request $request) | |||
| } | |||
|
|
|||
| $doctrine = $this->getDoctrine()->getManager(); | |||
| $attributeGroups = $doctrine->getRepository('PrestaShopBundle:Attribute')->findByLangAndShop(1, 1); | |||
| $language = empty($languages[0]) ? ['id_lang' => 1, 'id_shop' => 1] : $languages[0]; | |||
| $attributeGroups = $doctrine->getRepository('PrestaShopBundle:Attribute')->findByLangAndShop((int) $language['id_lang'], (int) ['id_shop']); | |||
There was a problem hiding this comment.
(int) ['id_shop'] is not and id.
|
You must read https://git-scm.com/book/en/v2/Git-Tools-Rewriting-History this is a really good article about how to rewrite history, from rewriting a git commit, to undo a commit, or squashing commits together =) |
|
Thanks @PierreRambaud |
This change is